Skip to content

template: allow dynamic config value lookup#9148

Open
fanzeyi wants to merge 1 commit intojj-vcs:mainfrom
fanzeyi:push-zrkqpnlqomrr
Open

template: allow dynamic config value lookup#9148
fanzeyi wants to merge 1 commit intojj-vcs:mainfrom
fanzeyi:push-zrkqpnlqomrr

Conversation

@fanzeyi
Copy link

@fanzeyi fanzeyi commented Mar 20, 2026

Fix: #9144

It looks like there is a comment talking about allowing dynamic configuration lookup for this function already. This PR implements that.

I would like to be able to show GitHub PR numbers that I store in my JJ configs. This allows me to write templates for jj log that shows PR numbers.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes
  • I fully understand the code that I am submitting (what it does,
    how it works, how it's organized), including any code drafted by an LLM.
  • For any prose generated by an LLM, I have proof-read and copy-edited with
    an eye towards deleting anything that is irrelevant, clarifying anything
    that is confusing, and adding details that are relevant. This includes,
    for example, commit descriptions, PR descriptions, and code comments.

@fanzeyi fanzeyi marked this pull request as ready for review March 20, 2026 07:10
@fanzeyi fanzeyi requested a review from a team as a code owner March 20, 2026 07:10
@fanzeyi fanzeyi force-pushed the push-zrkqpnlqomrr branch from 353fc97 to 4df250e Compare March 20, 2026 07:15
@fanzeyi fanzeyi force-pushed the push-zrkqpnlqomrr branch from 4df250e to 80a01f9 Compare March 21, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Relax StringLiteral requirement for config() in JJ Template

2 participants