fixed crash in commit/rollback #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix #146. Strange that this code worked before because callback args was only half filled. But maybe V8 was more lenient before. BTW, what's the advantage of having special C++ bindings for this? It could be implemented on top of execute. |
|
this has probably never worked, see #80 |
|
Confirmed that this patch fixes commit and rollback, +1 from me. |
johannish
added a commit
that referenced
this pull request
Feb 25, 2014
fixed crash in commit/rollback
I'm a little unsure of what you mean, could you elaborate? Doesn't having a separate Commit() function in C++ allow me more control, since I could run multiple statements in different transactions on the same connection? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.