Small cleanup on the 'mimic-native-api' branch#51
Merged
johannilsson merged 7 commits intojohannilsson:mimic-native-apifrom Jan 10, 2012
rfgamaral:mimic-native-api-cleanup
Merged
Small cleanup on the 'mimic-native-api' branch#51johannilsson merged 7 commits intojohannilsson:mimic-native-apifrom rfgamaral:mimic-native-api-cleanup
johannilsson merged 7 commits intojohannilsson:mimic-native-apifrom
rfgamaral:mimic-native-api-cleanup
Conversation
Owner
|
Merged. Agree on the renaming of Styles, this change does not affect apps that does not do heavy customization. It does not change any behavior either. If your app looks strange after this update, please refer to the new naming in styles.xml. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the promised cleanup we talked about :)
Hopefully, all those changes are acceptable... And like I said before, I don't know if GitHub allows you to pick the commits you want to merge because you might not like the last one "Keep styles consistent with Android naming conventions" but it's something I think you should change sooner or later, so, why not now? It's just a matter of code style but it's up to you :)