Tags: jorgearteiro/hcsshim
Tags
Merge pull request microsoft#991 from katiewasnothere/remove_extra_info Remove extra info from error logs
Merge pull request microsoft#956 from kevpar/ci-fix Improve CI reliability by forcing vendor use
Merge pull request microsoft#914 from dcantah/gitattributes Add .gitattributes to force LF line endings
Merge pull request microsoft#913 from dcantah/fix-nil-deref Fix nil dereference in `newHcsTask` if no shim options were passed
Merge pull request microsoft#910 from elweb9858/l4wfpproxy_portupdate Updating L4WfpProxyPolicy struct
Merge pull request microsoft#900 from dcantah/revendor-winio Revendor go-winio at d1ffc52c73318019ce58aaa5282588c52df029b7
Merge pull request microsoft#875 from katiewasnothere/modify_memory Add calls to modify UVM memory size and tests
Merge pull request microsoft#799 from microsoft/fix_test_go_mods Update test vendor with up to date hcsshim and containerd/containerd/log
Fix race condition in legacy process stdio code HcsCreateProcess returns a set of stdio handles for the newly created process. A while ago, we used to cache these handles and return them the first time stdio handles were requested for the process, and then get new handles via HcsGetProcessInfo for each subsequent request. At some point, this code was cleaned up to instead always return the original set of handles as non-closable (for new callers) and always get new handles via HcsGetProcessInfo (for legacy callers, who required closable handles). However, this change introduced a race condition for legacy callers, where in the case of a short lived container process, the container could have terminated between when it was started and when the orchestrator requested stdio handles. This led to ERROR_NOT_FOUND being returned from HcsGetProcessInfo. This change addresses this by returning the original handles the first time stdio handles are requested, and then calling HcsGetProcessInfo for every subsequent request (just as it used to work a while ago). Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
PreviousNext