Single partition aggregate #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Apr 25, 2018
## What changes were proposed in this pull request? Refactor continuous writing to its own class. See WIP jose-torres#13 for the overall direction this is going, but I think this PR is very isolated and necessary anyway. ## How was this patch tested? existing unit tests - refactoring only Author: Jose Torres <[email protected]> Closes apache#21116 from jose-torres/SPARK-24038.
jose-torres
force-pushed
the
singlePartitionAggregate
branch
from
9bdcf18 to
7463ac3
Compare
asfgit
pushed a commit
to apache/spark
that referenced
this pull request
May 4, 2018
…te() calls ## What changes were proposed in this pull request? Do continuous processing writes with multiple compute() calls. The current strategy (before this PR) is hacky; we just call next() on an iterator which has already returned hasNext = false, knowing that all the nodes we whitelist handle this properly. This will have to be changed before we can support more complex query plans. (In particular, I have a WIP jose-torres#13 which should be able to support aggregates in a single partition with minimal additional work.) Most of the changes here are just refactoring to accommodate the new model. The behavioral changes are: * The writer now calls prev.compute(split, context) once per epoch within the epoch loop. * ContinuousDataSourceRDD now spawns a ContinuousQueuedDataReader which is shared across multiple calls to compute() for the same partition. ## How was this patch tested? existing unit tests Author: Jose Torres <[email protected]> Closes #21200 from jose-torres/noAggr.
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
Refactor continuous writing to its own class. See WIP jose-torres#13 for the overall direction this is going, but I think this PR is very isolated and necessary anyway. existing unit tests - refactoring only Author: Jose Torres <[email protected]> Closes apache#21116 from jose-torres/SPARK-24038. Ref: LIHADOOP-48531 RB=1850759 G=superfriends-reviewers R=zolin,fli,latang,mshen,yezhou A=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.