-
Notifications
You must be signed in to change notification settings - Fork 16
Input decouple #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a decoupling of the entangled input property and the input component used for entering an autocomplete search item.
Problem: Because the input is x-model bound to the entangled input property on the model, on occasion if the user is typing too slowly, the livewire entangled update would interfere with the typed input. This is essentially a race condition between the input value and the livewire representation of the value.
Solution: Decouple the input from the entangled livewire property by adding a new Alpine property (debouncedValue). This property holds the value of the input value via an x-model binding. When the input is updated, the input() function will set the entangled value property and update the livewire component. When livewire sends subsequent updates for value, a $watch function listens for thoes updates and will only set the Alpine debouncedValue property if some conditions are present Thus it ignores livewire updates and breaks the input interference race condition. Livewire updates are processed if the debouncedValue is empty or null to allow for initial state setting (if a preset livewire value is present) and also when setSelected() has been called.
All tests passing but no extra failing tests were added.