Fix main test when run for a PR #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main test relies on the current GitHub event name, and that is populated via the environment variable GITHUB_EVENT_NAME. When you run locally, that's unset, and the test passes. When you run the workflow after pushing to main, it's set to "push", which isn't handled by main.ts, so it hits the default case and returns "not yet supported". But when the workflow is run in a PR, that env var is set to "pull_request" which is an event that main tries to handle. So the test fails in an unexpected way (throwing an error) instead of printing "not yet supported". I have updated the test to clear out GITHUB_EVENT_NAME so that we get the same test behavior in all cases. Signed-off-by: Carolyn Van Slyck <[email protected]>
jpmcb
approved these changes
May 13, 2022
Owner
jpmcb
left a comment
jpmcb
left a comment
There was a problem hiding this comment.
Great!!!!! Thanks so much for the investigation on this. This is a huuuuge value add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main test relies on the current GitHub event name, and that is populated via the environment variable GITHUB_EVENT_NAME.
When you run locally, that's unset, and the test passes.
When you run the workflow after pushing to main, it's set to "push", which isn't handled by main.ts, so it hits the default case and returns "not yet supported".
But when the workflow is run in a PR, that env var is set to "pull_request" which is an event that main tries to handle. So the test fails in an unexpected way (throwing an error) instead of printing "not yet supported".
I have updated the test to clear out GITHUB_EVENT_NAME so that we get the same test behavior in all cases.
Fixes #54