Refactor: Bring everything up to speed with new deps and node 18

.eslintrc.json

@@ -1,46 +1,48 @@
 {
     "plugins": ["jest", "@typescript-eslint"],
-    "extends": ["plugin:github/es6"],
+    "extends": [
+        "plugin:import/errors",
+        "plugin:import/warnings",
+        "plugin:import/typescript"
+    ],
     "parser": "@typescript-eslint/parser",
     "parserOptions": {
-      "ecmaVersion": 9,
+      "ecmaVersion": 2019,
       "sourceType": "module",
       "project": "./tsconfig.json"
     },
     "rules": {
       "eslint-comments/no-use": "off",
       "import/no-namespace": "off",
       "no-unused-vars": "off",
+      "camelcase": "off",
       "@typescript-eslint/no-unused-vars": "error",
       "@typescript-eslint/explicit-member-accessibility": ["error", {"accessibility": "no-public"}],
       "@typescript-eslint/no-require-imports": "error",
       "@typescript-eslint/array-type": "error",
       "@typescript-eslint/await-thenable": "error",
-      "@typescript-eslint/ban-ts-ignore": "error",
-      "camelcase": "off",
-      "@typescript-eslint/camelcase": "warn",
-      "@typescript-eslint/class-name-casing": "error",
+      "@typescript-eslint/ban-ts-comment": "error",
+      "@typescript-eslint/naming-convention": "warn",
       "@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}],
       "@typescript-eslint/func-call-spacing": ["error", "never"],
-      "@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
       "@typescript-eslint/no-array-constructor": "error",
       "@typescript-eslint/no-empty-interface": "error",
-      "@typescript-eslint/no-explicit-any": "error",
+      "@typescript-eslint/no-explicit-any": "warn",
       "@typescript-eslint/no-extraneous-class": "error",
       "@typescript-eslint/no-for-in-array": "error",
       "@typescript-eslint/no-inferrable-types": "error",
       "@typescript-eslint/no-misused-new": "error",
       "@typescript-eslint/no-namespace": "error",
       "@typescript-eslint/no-non-null-assertion": "warn",
-      "@typescript-eslint/no-object-literal-type-assertion": "error",
+      "@typescript-eslint/consistent-type-assertions": "error",
       "@typescript-eslint/no-unnecessary-qualifier": "error",
       "@typescript-eslint/no-unnecessary-type-assertion": "error",
       "@typescript-eslint/no-useless-constructor": "error",
       "@typescript-eslint/no-var-requires": "error",
       "@typescript-eslint/prefer-for-of": "warn",
       "@typescript-eslint/prefer-function-type": "warn",
       "@typescript-eslint/prefer-includes": "error",
-      "@typescript-eslint/prefer-interface": "error",
+      "@typescript-eslint/consistent-type-definitions": "error",
       "@typescript-eslint/prefer-string-starts-ends-with": "error",
       "@typescript-eslint/promise-function-async": "error",
       "@typescript-eslint/require-array-sort-compare": "error",
@@ -52,7 +54,12 @@
     },
     "env": {
       "node": true,
-      "es6": true,
       "jest/globals": true
+    },
+    "settings": {
+    "import/resolver": {
+      "typescript": true,
+      "node": true
     }
-  }
+  }
+}

__tests__/cronJobTest/labelPr.test.ts

@@ -1,4 +1,5 @@
-import nock from 'nock'
+import {setupServer} from 'msw/node'
+import {rest} from 'msw'
 
 import {handleCronJobs} from '../../src/cronJobs/handleCronJob'
 import * as utils from '../testUtils'
@@ -9,11 +10,35 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import prListFiles from '../fixtures/pullReq/pullReqListFiles.json'
 import prListTestFiles from '../fixtures/pullReq/pullReqListTestFiles.json'
 
-nock.disableNetConnect()
+const server = setupServer(
+  // /repos/Codertocat/Hello-World/pulls?page={1,2}
+  rest.get(
+    `${utils.api}/repos/Codertocat/Hello-World/pulls`,
+    (req, res, ctx) => {
+      const page = req.url.searchParams.get('page')
+
+      if (page == '1') {
+        return res(ctx.status(200), ctx.json(listPullReqs))
+      } else {
+        return res(ctx.status(200), ctx.json([]))
+      }
+    }
+  ),
+  rest.get(
+    `${utils.api}/repos/Codertocat/Hello-World/contents/.github%2Flabels.yaml`,
+    utils.mockResponse(200, labelFileContents)
+  )
+)
+beforeAll(() =>
+  server.listen({
+    onUnhandledRequest: 'warn'
+  })
+)
+afterEach(() => server.resetHandlers())
+afterAll(() => server.close())
 
 describe('cronLabelPr', () => {
   beforeEach(() => {
-    nock.cleanAll()
     utils.setupActionsEnv('/area')
   })
 
@@ -24,35 +49,22 @@ describe('cronLabelPr', () => {
     // Instead, we use it to gain the repo owner and url
     const context = new utils.mockContext(pullReqOpenedEvent)
 
-    nock(utils.api)
-      .get('/repos/Codertocat/Hello-World/pulls?page=1')
-      .reply(200, listPullReqs)
-
-    nock(utils.api)
-      .get('/repos/Codertocat/Hello-World/pulls?page=2')
-      .reply(200, [])
-
-    let parsedBody = undefined
-    const scope = nock(utils.api)
-      .post('/repos/Codertocat/Hello-World/issues/2/labels', body => {
-        parsedBody = body
-        return body
-      })
-      .reply(200)
-
-    nock(utils.api)
-      .get('/repos/Codertocat/Hello-World/contents/.github/labels.yaml')
-      .reply(200, labelFileContents)
-
-    nock(utils.api)
-      .get('/repos/Codertocat/Hello-World/pulls/2/files')
-      .reply(200, prListFiles)
-
-    await handleCronJobs(context)
-    expect(parsedBody).toEqual({
+    const observeReq = new utils.observeRequest()
+    server.use(
+      rest.post(
+        `${utils.api}/repos/Codertocat/Hello-World/issues/2/labels`,
+        utils.mockResponse(200, null, observeReq)
+      ),
+      rest.get(
+        `${utils.api}/repos/Codertocat/Hello-World/pulls/2/files`,
+        utils.mockResponse(200, prListFiles)
+      )
+    )
+
+    await expect(handleCronJobs(context)).resolves.not.toThrow()
+    expect(observeReq.body()).toEqual({
       labels: ['source']
     })
-    expect(scope.isDone()).toBe(true)
   })
 
   it('labels the PR with the test label from glob', async () => {
@@ -62,34 +74,22 @@ describe('cronLabelPr', () => {
     // Instead, we use it to gain the repo owner and url
     const context = new utils.mockContext(pullReqOpenedEvent)
 
-    nock(utils.api)
-      .get('/repos/Codertocat/Hello-World/pulls?page=1')
-      .reply(200, listPullReqs)
-
-    nock(utils.api)
-      .get('/repos/Codertocat/Hello-World/pulls?page=2')
-      .reply(200, [])
-
-    let parsedBody = undefined
-    const scope = nock(utils.api)
-      .post('/repos/Codertocat/Hello-World/issues/2/labels', body => {
-        parsedBody = body
-        return body
-      })
-      .reply(200)
-
-    nock(utils.api)
-      .get('/repos/Codertocat/Hello-World/contents/.github/labels.yaml')
-      .reply(200, labelFileContents)
-
-    nock(utils.api)
-      .get('/repos/Codertocat/Hello-World/pulls/2/files')
-      .reply(200, prListTestFiles)
-
-    await handleCronJobs(context)
-    expect(parsedBody).toEqual({
+    const observeReq = new utils.observeRequest()
+    server.use(
+      rest.post(
+        `${utils.api}/repos/Codertocat/Hello-World/issues/2/labels`,
+        utils.mockResponse(200, null, observeReq)
+      ),
+
+      rest.get(
+        `${utils.api}/repos/Codertocat/Hello-World/pulls/2/files`,
+        utils.mockResponse(200, prListTestFiles)
+      )
+    )
+
+    await expect(handleCronJobs(context)).resolves.not.toThrow()
+    expect(observeReq.body()).toEqual({
       labels: ['tests']
     })
-    expect(scope.isDone()).toBe(true)
   })
 })