Add length to the url field and index #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL errors while adding the index because it likes a known length. Within StackOverflow there is also a discussion regarding defacto max url length so I set the `url` limit to the known max of 2083. https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of -a-url-in-different-browsers
Owner
|
Seems reasonable - can you please update the readme to note this limitation @craigmcnamara . |
Warn about url length and default index length.
Collaborator
Author
|
I added a warning label to the generator instructions. |
jpmcgrath
approved these changes
Apr 30, 2018
Owner
|
This will be released shortly in version v0.7.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL errors while adding the index because it likes a known length.
Within StackOverflow there is also a discussion regarding defacto max
url length so I set the
urllimit to the known max of 2083.https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of
-a-url-in-different-browsers