Skip to content

Conversation

@ManasJayanth
Copy link
Collaborator

@ManasJayanth ManasJayanth commented Dec 19, 2017

WIP. I'm looking for feedback, overall viability and other concerns. Basic idea: Map react-dom to react-dom-lite using jest's module mapper. Running yarn test-rdl inside react would run only react-dom tests, with react-dom resolving to react-dom-lite.

@jquense
Copy link
Owner

jquense commented Dec 19, 2017

nice! I don't have much familiarity with git submodules, except that folks say they are hard to work with and should be avoided (no idea if that's relevant here).

My other thought for doing this was to maybe manually pull the repo and copy the test files into a react-tests folder periodically. Might be easy than worrying about submodules (especially for others contributing), WDYT?

@ManasJayanth
Copy link
Collaborator Author

pull the repo and copy the test files into a react-tests folder periodically. Might be easy than worrying about submodules

Completely agreed. Just that I'm exploring ways to do it with a tool. Hate the fact that it has to be git submodules

especially for others contributing

Ideally they must not be touched by anyone else. I'm hoping react's tests would serve like es6's test262

@jquense
Copy link
Owner

jquense commented Dec 19, 2017

Ideally they must not be touched by anyone else. I'm hoping react's tests would serve like es6's test262

yeah, tho if we use submodules that won't be the case, you need to somewhat aware of them to even properly clone the repo yeah?

I was thinking build a script that git clones react into a tmp folder, cp react-dom//tests into vendor-tests or something

@ManasJayanth
Copy link
Collaborator Author

I was thinking build a script that git clones react into a tmp folder, cp react-dom//tests into vendor-tests or something

Seems like a good idea. But I dont understand what you mean by

yeah, tho if we use submodules that won't be the case, you need to somewhat aware of them to even properly clone the repo yeah?

@ManasJayanth
Copy link
Collaborator Author

Closing this. Superseded by PR #18

@ManasJayanth ManasJayanth deleted the add-reacts-test-suite branch January 27, 2018 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants