Store prefix lenght to private property _prefixLenght#71
Merged
jsakamoto merged 2 commits intojsakamoto:masterfrom Mar 9, 2021
Merged
Store prefix lenght to private property _prefixLenght#71jsakamoto merged 2 commits intojsakamoto:masterfrom
jsakamoto merged 2 commits intojsakamoto:masterfrom
Conversation
…imise multiple calls GetPrefixLength().
Owner
Fix the typing error in "_prefixLenght"
Contributor
Author
|
@jsakamoto Thank you, good point, you are right. I have fixed it. PS: I'm sorry for my English |
Owner
|
@KamilZm Thank you for your effort! I'll merge this pull request as soon as possible, and I'll publish a new version of this package. P.S.
Don't mind! I'm also a not-native English speaker. 😄 |
Owner
|
I merged your pull request just now, and I published the new version of this package! 🎉 Again, thank you for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetPrefixLength() is very expensive method. If you call it many times (I have to +-1000000 calls), it will take a very long time.
I store prefix lenght to private property _prefixLenght in order to optimise multiple calls GetPrefixLength().
Number of calls: 1000000
Without optimalisation 14635 ms
With optimalisation: 4 ms