Skip to content

Add falsely passing double array roundtrip test #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 16, 2019
Merged

Add falsely passing double array roundtrip test #17

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d95d7cc
Add benchmarking data
bwetherfield Jul 15, 2019
feb26d1
Add containsChoice juncture for Unboxed key encoding
bwetherfield Jul 16, 2019
027bcb9
Add Array containing XMLChoiceEncodable type
bwetherfield Jul 16, 2019
b0e6ddf
Remove stray print statement
bwetherfield Jul 16, 2019
22d1a9c
Add fix for pretty printing
bwetherfield Jul 16, 2019
fc29bd4
Fix typo
bwetherfield Jul 16, 2019
a7253f6
Merge branch 'bean/xmlchoicecodable' into wetherfield/xmlchoiceencodable
bwetherfield Jul 16, 2019
8809ff4
Add failing test
bwetherfield Jul 16, 2019
ea50c66
Fix formatting
bwetherfield Jul 16, 2019
a4d9f24
Merge branch 'bean/xmlchoicecodable' into wetherfield/xmlchoiceencodable
jsbean Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix formatting
  • Loading branch information
@bwetherfield
bwetherfield committed Jul 16, 2019
commit ea50c664a31f55d0cd077c2051b4e4ba4ce39603
1 change: 0 additions & 1 deletion Sources/XMLCoder/Auxiliaries/Box/SingleElementBox.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ struct SingleElementBox: SimpleBox {
}

extension SingleElementBox: Box {

var isNull: Bool {
return false
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/XMLCoderTests/SimpleChoiceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class SimpleChoiceTests: XCTestCase {
let decoded = try XMLDecoder().decode([IntOrString].self, from: encoded)
XCTAssertEqual(original, decoded)
}

func testIntOrStringDoubleArrayRoundTrip() throws {
let original: [[IntOrString]] = [[
.int(1),
Expand Down