Fix/source enabled (elastic#3015)

* SourceEnabled() used to take string[] which adheres to the spec but since we also have SourceInclude/Exclude it makes more sense for this parameter to be a bool in the client

* Generated request parameters value types should be nullable to reflect their absence on the querystring

* generated request parameters on descriptors that take a value type should also be nullable

* reran code generation after rebase

Author: Mpdreamz

src/CodeGeneration/ApiGenerator/Domain/ApiEndpoint.cs

@@ -325,6 +325,8 @@ private void PatchRequestParameters(IEndpointOverrides overrides)
 				if (globalOverrides.RenderPartial.Contains(newName))
 					kv.Value.RenderPartial = true;
 
+				//make sure source_enabled takes a boolean only
+				if (newName == "source_enabled") kv.Value.Type = "boolean";
 
 				patchedParams.Add(newName, kv.Value);
 			}

src/CodeGeneration/ApiGenerator/Domain/ApiQueryParameters.cs

@@ -13,8 +13,6 @@ public class ApiQueryParameters
 		public string Obsolete { get; set; }
 		public IEnumerable<string> Options { get; set; }
 
-
-
 		public string CsharpType(string paramName)
 		{
 			switch (this.Type)
@@ -56,6 +54,9 @@ public IEnumerable<string> HighLevelTypeDescription(string paramName)
 					yield return "<para>For requests that are constructed from/for a document NEST will automatically infer the routing key";
 					yield return "if that document has a <see cref=\"Nest.JoinField\" /> or a routing mapping on for its type exists on <see cref=\"Nest.ConnectionSettings\" /></para> ";
 					yield break;
+				case "source_enabled":
+					yield return "Whether the _source should be included in the response.";
+					yield break;
 				default:
 					yield return this.Description;
 					yield break;
@@ -80,13 +81,25 @@ public string HighLevelType(string paramName)
 				case "string" when isFields: return "Fields";
 				case "string" when o.Contains("field"): return "Field";
 				default:
-					return csharpType;
+					return NullableCsharpType(csharpType);
+			}
+		}
+		private static string NullableCsharpType(string fieldType)
+		{
+			switch (fieldType)
+			{
+				case "bool": return "bool?";
+				case "integer": return "int?";
+				case "double": return "double?";
+				case "long": return "long?";
+				default:
+					return fieldType;
 			}
 		}
 
 		public Func<string, string, string, string, string> Generator { get; set; } =
 			(fieldType, mm, original, setter) =>
-				$"public {fieldType} {mm} {{ get {{ return Q<{fieldType}>(\"{original}\"); }} set {{ Q(\"{original}\", {setter}); }} }}";
+				$"public {NullableCsharpType(fieldType)} {mm} {{ get {{ return Q<{NullableCsharpType(fieldType)}>(\"{original}\"); }} set {{ Q(\"{original}\", {setter}); }} }}";
 
 		public Func<string, string, string, string, string> FluentGenerator { get; set; }
 

src/CodeGeneration/ApiGenerator/Views/_Descriptors.Generated.cshtml

@@ -54,7 +54,7 @@ namespace Nest
         }
 		var t = @kv.Value.HighLevelType(kv.Key);
 		var tMethod = t == "Time" ? ".ToTimeSpan()" : "";
-		var tSuffix = (t == "bool") ? " = true" : "";
+		var tSuffix = (t == "bool" || t == "bool?") ? " = true" : "";
 		var m = kv.Key.ToPascalCase();
 		var mm = (m != "Type" && m != "Index" && m != "Source" && m != "Script") ? m : m + "QueryString";
 		var typed = !method.DescriptorTypeGeneric.IsNullOrEmpty();

src/Elasticsearch.Net/Domain/RequestParameters/RequestParameters.Generated.cs

@@ -32,7 +32,7 @@ protected override LazyResponses ClientUsage() => Calls(
 
 		protected override ExplainDescriptor<Project> NewDescriptor() => new ExplainDescriptor<Project>(_project);
 
-		private Project _project = new Project { Name = Project.Instance.Name };
+		private readonly Project _project = new Project { Name = Project.Instance.Name };
 
 		protected override object ExpectJson => new
 		{
@@ -49,7 +49,7 @@ protected override LazyResponses ClientUsage() => Calls(
 		};
 
 		protected override Func<ExplainDescriptor<Project>, IExplainRequest<Project>> Fluent => e => e
-			.SourceEnabled("true") //TODO this should be generated as a bool
+			.SourceEnabled()
 			.Query(q => q
 				.Match(m => m
 					.Field(p => p.Name)
@@ -59,7 +59,7 @@ protected override LazyResponses ClientUsage() => Calls(
 
 		protected override ExplainRequest<Project> Initializer => new ExplainRequest<Project>(_project)
 		{
-			SourceEnabled = new [] { "true" },
+			SourceEnabled = true,
 			Query = new QueryContainer(new MatchQuery
 			{
 				Field = "name",