Fix/source enabled #3015
Merged
Fix/source enabled #3015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince we also have SourceInclude/Exclude it makes more sense for this parameter to be a bool in the client
…t their absence on the querystring
…ould also be nullable
Mpdreamz
force-pushed
the
fix/source-enabled
branch
from
b40d911 to
8a7dfbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
.SourceEnabled(string[] enabled)while adhering to the spec makes little sense in the client. We only allow a boolean to be passed now. You can still useSourceInclude()andSourceInclude()Request parameter's value types should be nullable so that they be passed
nullto force no value to be send. Also the getters onRequestwould otherwise fallback todefault(bool)which is not always technically the default on the server.