Disable Selection #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for implementing this, it's missing the check inside the link function of the directive for $scope.isDisabled at about line 251 though. |
Contributor
Author
|
@gavinbarron will add that. but the look goes disabled? is that okay? |
Collaborator
|
My personal opinion is that if a UI element is disabled and does nothing when you click on it it's better to give the user some visual clues that is the case so that they're not left wondering why their clicks do nothing. |
Collaborator
|
You'll need to update this with the changes that have been merged to master |
Contributor
Author
|
Ping @gavinbarron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59
Disabled look is purposefully left out. Let me know if you want this to be added.