A few small fixes for strict compiler settings. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially the fix in the header is important because it forces one to tone down compile strictness if you want to include this header. Compiled with gcc and added at least -Wextra -Werror -Wstrict-prototypes -Wmissing-prototypes.
The suffix ".0" was being added to every serialize double leading to numbers like 1e-28.0 and 4e-06.0 (instead of 1e-28 and 4e-06).
Just to save a few bytes when compiling for embedded systems.
Doesn't fail currently, but good to check for!
|
Thanks! I haven't made an AUTHORS for this one yet but I will. If you'd like to be included, do you have a preferred name? |
|
I was slightly lazy when I created a pull request from the master branch of my fork, which made you merge more than I initially intended ... 😟 ... (not sure if you agree with the removing libm dependency). Unfortunately I made a mistake (compilation failure on visual studio in release mode) in commit d6eb388 which I fix here marcelmeulemans@3196323 About the AUTHORS, up to you, just use my name. |
|
I intended to merge them all 👍 Will merge the other commit too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially the fix in the header is important because it forces one to tone
down compile strictness if you want to include this header. Compiled with
gcc and added at least -Wextra -Werror -Wstrict-prototypes
-Wmissing-prototypes.