Skip to content

Feature: clean model when a field is removed from view, such as when a condition is no longer satisfied. #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 10, 2015
Merged

Feature: clean model when a field is removed from view, such as when a condition is no longer satisfied. #371

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3ab26b4
Update README.md
Dervisevic May 1, 2015
e5c6183
Update README.md
Dervisevic May 1, 2015
3353cca
Extended schema-validate directive to handle cleaning the model when …
jbsaff Apr 28, 2015
896ec3e
Additional doc example.
jbsaff Apr 28, 2015
e73bfe2
Part of another branch pull request.
jbsaff Apr 28, 2015
76a562c
Fixes from code review in #371. Reworked the default destroyStrategy …
jbsaff Apr 30, 2015
0d6f417
Removed extra console logging.
jbsaff Apr 30, 2015
4568337
Only clean model if the form's condition is no longer satisfied. This…
jbsaff May 1, 2015
4d72f3d
Merge remote-tracking branch 'origin/feature/cleanModelUsingDestroySt…
jbsaff May 1, 2015
d20b273
Remove extraneous console log.
jbsaff May 1, 2015
dcff62b
sfSchema can communicate via sfRetainModel service to force the model…
jbsaff May 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed extra console logging.
  • Loading branch information
@jbsaff
jbsaff committed May 1, 2015
commit 0d6f417f1039840789205d769e2eb36583a956ee
2 changes: 0 additions & 2 deletions src/directives/schema-validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,12 +150,10 @@ angular.module('schemaForm').directive('schemaValidate', ['sfValidator', 'sfSele
if (destroyStrategy === 'retain') {
return; // Valid option to avoid destroying data in the model.
}
console.log('result %s', destroyStrategy);

destroyUsingStrategy(destroyStrategy);

function destroyUsingStrategy(strategy) {
console.log('Destroy called with %s', strategy);
var strategyIsDefined = (strategy === null || strategy === '' || strategy === undefined);
if (!strategyIsDefined){
strategy = DEFAULT_DESTROY_STRATEGY;
Expand Down