more allowedTypes

[krzyzanowskim]

Consider add this types to allowed types

NSDecimalNumber
__NSArrayM
__NSArrayI
__NSDictionaryM
__NSDictionaryI

[icanzilb]

Will add them to the list. Any idea how to handle this whole class mapping thing in a better way?

[krzyzanowskim]

my only thing about class mapping is that is we;l... it take a little to much time for not so big jsons.
This is because whole json is mapped at once. Just an idea to do something like "lazy" mapping, where subarrays and subdictionaries would be mapped only if accessed (via getter method), and default mapping would be "shallow" and fast.

[icanzilb]

Did you try some models, which seem to take a lot of time to initialise? And what file size the JSON had in this case?

[krzyzanowskim]

31kb json file I worked, took something about 0.6s on iPad2, comparing to NSJSONSerialization (to NSDictionary) took significant difference.

[icanzilb]

it should take more time for sure, because there are many things happening - validation, retrospection, etc.
I'll need to make some benchmarking myself, but it looks like this is a valuable idea - lazy loading might be the answer.

[icanzilb]

ok related to an idea that @brendonblackwell gave me, I think normal NSArray and NSDictionary properties should load and parse everything at once - these I'd use for custom API communication, where the amount of JSON would relatively small.

I think it's best if there's a separate collection class which would then provide iteration and searching methods, and also lazy load models when objects are being fetched from the collection

[icanzilb]

@krzak - I have few speed optimizations done to the Master branch - could you have a look again, tell me if it's faster for you?

Also - https://github.com/icanzilb/JSONModel/tree/JSONModelArray - on this branch I'm working on the NSArray which converts dictionaries to JSONModels on demand. Basically your JSON stays stored as an NSDictionary, first time you access it gets converted to JSONModel, then you get the JSONModel instance if you access again the same index in the NSArray.

How do you like the idea? This should solve the speed problem when you have a huge feed right? Let me know what do you think. Open a new issue about it if you feel like.