Skip to content

Async work in R2R #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtschuster wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Async work in R2R #3

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
6658d8b
Pass async jit flag to jit in aot tools
jtschuster Oct 15, 2025
1f917e9
Add IsRuntimeAsync override to instantiated MethodDescs
jtschuster Oct 15, 2025
431bfaa
Update src/coreclr/tools/Common/TypeSystem/Common/InstantiatedMethod.cs
jkotas Oct 15, 2025
3a4ffbc
Rename IsRuntimeAsync to IsAsync, add override in MethodDelegator
jtschuster Oct 16, 2025
1030acb
Add AsyncMethodDesc for AsyncCallConv methods
jtschuster Oct 17, 2025
4cc1f5f
Merge branch 'main' of https://github.com/dotnet/runtime into AsyncMe…
jtschuster Oct 17, 2025
7516cba
Remove comments from AsyncMethodDesc
jtschuster Oct 17, 2025
42e1157
Use MethodSignatureBuilder and assert for expected invariants
jtschuster Oct 17, 2025
429f910
Use throwing cast instead of 'as' cast
jtschuster Oct 17, 2025
4e0d53d
Fix assert
jtschuster Oct 17, 2025
c75c536
Add getter to Flags for |=
jtschuster Oct 17, 2025
e8ef453
Implement getAsyncInfo in ILCompiler
jtschuster Oct 17, 2025
5ff7bc6
Use Dictionary instead of ConcurrentDictionary for AsyncMethodDescFac…
jtschuster Oct 17, 2025
e5ea4ce
Refactor AsyncMethodDesc for clarity and efficiency
jtschuster Oct 17, 2025
0cf52dc
Update src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
jtschuster Oct 17, 2025
de10bb5
Update Signature and delete GetOtherAsyncMethod
jtschuster Oct 17, 2025
ff2712d
Remove IsAsync requirement from AsyncMethodDesc
jtschuster Oct 17, 2025
9749653
Formatting and remove unused accessor
jtschuster Oct 17, 2025
c2e3c48
Merge branch 'GetAsyncInfoR2R' into AsyncMethodDesc
jtschuster Oct 17, 2025
7bb7b1b
Merge branch 'main' of https://github.com/dotnet/runtime into GetAsyn…
jtschuster Oct 18, 2025
a728fdb
Use new CORINFO_ASYNC_INFO, PR Feedback
jtschuster Oct 19, 2025
bada361
Delete old UnboxingMethodDescFactory, move AsyncMethodDescFactory to …
jtschuster Oct 20, 2025
5fd0330
Merge branch 'GetAsyncInfoR2R' into AsyncR2R
jtschuster Oct 20, 2025
1bae281
Add support for async method wrappers and related functionality
jtschuster Oct 22, 2025
0b4dca8
Merge branch 'main' of https://github.com/dotnet/runtime into AsyncR2R
jtschuster Oct 22, 2025
0e6d23c
Couple other cleanup fixes
jtschuster Oct 22, 2025
a828d07
Adjustment to get the compiler to finish the jitting
davidwrighton Oct 23, 2025
7f24e0b
WIP
jtschuster Oct 23, 2025
4802a7f
Merge pull request #2 from davidwrighton/AsyncR2RTweaks
jtschuster Oct 23, 2025
4834a15
Merge branch 'AsyncR2R' of https://github.com/jtschuster/runtime into…
jtschuster Oct 23, 2025
cfb856b
Compiling, runs until failed assert
jtschuster Oct 26, 2025
7643bb9
Remove unused TaskReturningAsyncWrapper and undo formatting changes
jtschuster Oct 26, 2025
845b5d3
Runs the R2R image without jitting main when main doesnt await
jtschuster Oct 29, 2025
a9dafc3
Create thunk MethodDescs, put thunks into InstanceMethod
jtschuster Oct 30, 2025
89f9d1d
Update csproj
jtschuster Oct 30, 2025
c9a3382
Merge branch 'main' of https://github.com/dotnet/runtime into AsyncR2R
jtschuster Oct 30, 2025
fe73474
Just committing everything for now
jtschuster Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix assert
  • Loading branch information
@jtschuster
jtschuster committed Oct 17, 2025
commit 4e0d53deddf32b650f104448dcf2fc0caac1cebe
2 changes: 1 addition & 1 deletion src/coreclr/tools/Common/JitInterface/AsyncMethodDesc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public override MethodSignature Signature
}
else if (name.SequenceEqual("Task`1"u8) || name.SequenceEqual("ValueTask`1"u8))
{
Debug.Assert(returnType.HasInstantiation);
Debug.Assert(md.HasInstantiation);
returnType = md.Instantiation[0];
}
else
Expand Down