Fix missing URI conversion in code action execution.#1074
Merged
Conversation
Member
Author
|
Hmm, okay, maybe it is specific to neovim somehow then? |
Member
Author
|
No probably doesn't work anywhere, I think the problem is that in the tests the client directly call the server without JSON serialization/deserialization. |
Member
|
There is probably no harm in adding URI(uri::URI) = urito fix the current test failure, right? |
pfitzseb
reviewed
May 5, 2022
| uri = URI(params.arguments[1]) | ||
| offset = params.arguments[2] | ||
| doc = getdocument(server, uri) | ||
| x = get_expr(getcst(doc), offset) |
Member
There was a problem hiding this comment.
I've moved the uri/offset extraction into the if block because that "calling convention" is only valid for actions we define ourselves, and who knows what a client might send.
davidanthoff
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am confused how CI passed without this, this path should be tested by
LanguageServer.jl/test/requests/actions.jl
Line 8 in 0955a4d