Remove didSave notification handler

[pfitzseb]

No description provided.

[davidanthoff]

Copying a comment I just left on Slack:

I think actually that we added the didSave handler exclusively to diagnose text sync bugs. The thinking was essentially that it would be a way to compare the entire doc document at a specified "sync" point, and if we don't get crash reports from that we could be very, very certain that our text sync implementation is correct, without trying to diagnose individual didChange workflows.

So I'm starting to wonder whether we really should disable it, or try to figure out what exactly is going on, because by our old logic, if we see crashes here, there is something wrong in our text sync implementation...

[pfitzseb]

I'm not sure the premise is entirely correct -- I'll ask upstream whether there's any guarantee for getting didChange before didSave.

[davidanthoff]

I'm not sure the premise is entirely correct

What speaks in favor of the premise, though, is that we haven't seen this crash at all for months, if not years, in our crash reporting, AFAIK.

[pfitzseb]

True. The client side behaviour does appear to change with the new LSP release though (julia-vscode/julia-vscode#2886, in case you wanna give it a go).

[davidanthoff]

Maybe we should report this as a bug in the new client side implementation?