Skip to content

Compat: Allow JuliaFormatter 0.23.X.#1093

Merged
fredrikekre merged 1 commit intomasterfrom
fe/jlfmt
May 23, 2022
Merged

Compat: Allow JuliaFormatter 0.23.X.#1093
fredrikekre merged 1 commit intomasterfrom
fe/jlfmt

Conversation

@fredrikekre
Copy link
Copy Markdown
Member

Doesn't seem to be anything breaking in domluna/JuliaFormatter.jl@v0.22.11...v0.23.0, right @domluna? Should probably have been 0.22.12 then.

@fredrikekre fredrikekre merged commit 70ceb97 into master May 23, 2022
@fredrikekre fredrikekre deleted the fe/jlfmt branch May 23, 2022 11:55
@domluna
Copy link
Copy Markdown

domluna commented May 23, 2022

didn't think about LanguageServer compat. Oops. Whenever I add a new option I have a habit of bumping the minor version.

@fredrikekre
Copy link
Copy Markdown
Member Author

Pre 1.0 you shouldn't do that unless something is breaking, see https://pkgdocs.julialang.org/v1/compatibility/#compat-pre-1.0.

@davidanthoff
Copy link
Copy Markdown
Member

I would just tag 1.0.0 and then one can signal much better what each release does :)

@domluna
Copy link
Copy Markdown

domluna commented May 24, 2022

I would just tag 1.0.0 and then one can signal much better what each release does :)

Yeah that's a good idea

@domluna
Copy link
Copy Markdown

domluna commented May 24, 2022

I'm going to tag 1.0.0 after merging the SciMLStyle PR domluna/JuliaFormatter.jl#588

seems a good enough place as any

@davidanthoff
Copy link
Copy Markdown
Member

Ok, after looking at things again, I think it would actually be nice if we could resolve domluna/JuliaFormatter.jl#559 before a 1.0 tag :) Probably best to discuss that over in that issue, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants