Merged
Conversation
This adds a new _language_id field to TextDocument, which can be queried downstream. It's important to not look at line endings here, because the client may set the language to some arbitrary value which may or may not match the extension.
This was referenced Aug 15, 2022
davidanthoff
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new _language_id field to TextDocument, which
can be queried downstream. It's important to not look at
line endings here, because the client may set the language
to some arbitrary value which may or may not match
the extension.
An added bonus is that we don't try to parse quite as much
invalid julia code -- the previous implementation would try to
parse each markdown file as Julia and then extract Julia code
blocks from that.