Fix symbol server error handling on older Julia versions#572
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
+ Coverage 29.87% 29.94% +0.06%
==========================================
Files 22 23 +1
Lines 1590 1593 +3
==========================================
+ Hits 475 477 +2
- Misses 1115 1116 +1
Continue to review full report at Codecov.
|
ZacLN
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an error from crash reporting.
I'm also introducing a new exception type here. The crash reporting can distinguish different different exception types, so this way we don't lump all
ErrorExceptionsinto the same bucket.