Skip to content

mark var"" missings#634

Merged
davidanthoff merged 3 commits into
masterfrom
varmissing
Apr 20, 2020
Merged

mark var"" missings#634
davidanthoff merged 3 commits into
masterfrom
varmissing

Conversation

@ZacLN

@ZacLN ZacLN commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Marking missing Symbols that use var"something" syntax

@ZacLN
ZacLN requested a review from davidanthoff April 17, 2020 17:00
davidanthoff
davidanthoff previously approved these changes Apr 17, 2020

@davidanthoff davidanthoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe wait with merging of this until we've had a build that made it out to the release channel, and then merge?

Right now I pushed a new insider build a few hours ago, if that doesn't show regressions, I will release to everyone sometime tomorrow.

@davidanthoff davidanthoff added this to the Backlog milestone Apr 17, 2020
@ZacLN

ZacLN commented Apr 17, 2020

Copy link
Copy Markdown
Contributor Author

Whatever's easiest for you

@davidanthoff davidanthoff modified the milestones: Backlog, Current Apr 17, 2020
@davidanthoff

Copy link
Copy Markdown
Member

Cool, I'll just merge once the new release is out, hopefully tomorrow.

@davidanthoff
davidanthoff merged commit 165c79b into master Apr 20, 2020
@davidanthoff
davidanthoff deleted the varmissing branch April 20, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants