Refactor ternary expressions to plain get#662
Merged
Conversation
This saves a dictionary lookup and is easier to read. This also may make debugging julia-vscode#600 easier since there was a bug I fixed where response["error"]["data"] was getting thrown away and response["error"]["code"] used instead.
ZacLN
approved these changes
May 5, 2020
davidanthoff
approved these changes
May 6, 2020
davidanthoff
left a comment
davidanthoff
left a comment
Member
There was a problem hiding this comment.
I'll merge once CI has passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves a dictionary lookup and is easier to read. This also may
make debugging #600 easier since there was a bug where
response["error"]["data"]was getting thrown away andresponse["error"]["code"]used instead.