Remove debug_mode field from LanguageServerInstance#664
Merged
Conversation
Member
Author
|
Note that this requires a major version bump since the signature of the single documented, exported symbol changed. |
davidanthoff
previously approved these changes
May 6, 2020
davidanthoff
left a comment
davidanthoff
left a comment
Member
There was a problem hiding this comment.
I'm in favor! @ZacLN, are you also on board?
We should just use @debug for any debug output, and then use the normal logging methods of displaying that if we want it.
Member
|
@non-Jedi, can you resolve the merge conflict? |
There are no longer any uses of this field inside LanguageServer.jl. If the vs-code extension still sends "julia/toggle-log" methods, it should be removed since it functionally changes nothing currently. Closes julia-vscode#421
non-Jedi
force-pushed
the
remove-debug-mode
branch
from
May 6, 2020 13:13
cb8ab45 to
9f10e39
Compare
Member
Author
|
Rebased and force-pushed to resolve merge conflict. |
davidanthoff
approved these changes
May 6, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no longer any uses of this field inside
LanguageServer.jl. If the vs-code extension still sends
"julia/toggle-log" methods, it should be removed since it functionally
changes nothing currently.
Closes #421
I couldn't get the tests to run locally, so I'm depending on CI to see if anything is broken.