update config & lint checks, remove unneeded fields#683
Merged
davidanthoff merged 2 commits intomasterfrom May 8, 2020
Merged
Conversation
Member
|
StaticLint v4.2.0 is tagged, so Project.toml here can be updated. |
davidanthoff
previously approved these changes
May 8, 2020
davidanthoff
approved these changes
May 8, 2020
non-Jedi
reviewed
May 8, 2020
| ConfigurationItem(missing, "julia.lint.missingrefs") | ||
| ])) | ||
|
|
||
| new_DF_opts = DocumentFormat.FormatOptions([isnothing(opt) ? DocumentFormat.default_options[i] : opt for (i,opt) in enumerate(response[1:11])]...) |
Member
There was a problem hiding this comment.
The point of the constructors in DocumentFormat/StaticLint was so that doing these kind of checks for nothingness here is unnecessary. Is the concern that the language server receives non-Bool, non-nothing responses?
Suggested change
| new_DF_opts = DocumentFormat.FormatOptions([isnothing(opt) ? DocumentFormat.default_options[i] : opt for (i,opt) in enumerate(response[1:11])]...) | |
| new_DF_opts = DocumentFormat.FormatOptions(response[1:11]...) |
Contributor
Author
There was a problem hiding this comment.
Sorry, I absolutely missed that - was a bit of a rush job. Could you make a PR to revert this?
This was referenced May 8, 2020
non-Jedi
added a commit
to non-Jedi/LanguageServer.jl
that referenced
this pull request
May 8, 2020
julia-vscode#683 needs latest versions. Ideally General registry should be updated as well.
This was referenced May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mark_errors.default_optionsvariables in DocFormat/SL to set config (these are now all on by default).-Requires turn checks on by default, add missingref options StaticLint.jl#160 and SL probably needs a little ver bump.