Merged
Conversation
Contributor
|
It's almost certainly coming from within StaticLint but this isn't related to whether a file is in the workspace or not. I don't think this PR would give us the info we need (it'll notify of the issue but not how it's come about), I'll make one for SL |
Member
Author
|
We should probably still merge this, right? It can't harm and essentially would make sure we would notice any problem in this area. |
ZacLN
approved these changes
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps diagnose #703.
The general idea is that we want to figure out where relative paths come from, and this might help us to narrow that scenario down. My understanding is that we will never receive a URI from a client with a relative path, but that those relative paths originate somewhere in our own code, maybe in the include following logic of StaticLint? Of course, I would just generally remove any loading of non-workspace files from disc :)
CC @pxl-th and @non-Jedi.