Skip to content

Add isnothing for Julia < 1.1#724

Merged
davidanthoff merged 2 commits intomasterfrom
isnothing
May 28, 2020
Merged

Add isnothing for Julia < 1.1#724
davidanthoff merged 2 commits intomasterfrom
isnothing

Conversation

@davidanthoff
Copy link
Copy Markdown
Member

@davidanthoff davidanthoff commented May 27, 2020

Leading to bugs in the wild right now, we should ship quickly.

@davidanthoff davidanthoff added this to the Current milestone May 27, 2020
@davidanthoff davidanthoff self-assigned this May 27, 2020
@davidanthoff davidanthoff merged commit ef93546 into master May 28, 2020
@davidanthoff davidanthoff deleted the isnothing branch May 28, 2020 03:40
@non-Jedi
Copy link
Copy Markdown
Member

non-Jedi commented May 28, 2020 •
edited
Loading

For reference, if isnothing is ever in a performance critical section of code, === nothing should be preferred: JuliaLang/julia#27681

isnothing is often more convenient/terse, so I'm definitely not advocating avoiding it, but I found this surprising when I learned, so I thought it worth mentioning.

@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aviatesk aviatesk aviatesk approved these changes

Assignees

@davidanthoff davidanthoff

Labels

bug

Projects

None yet

Milestone

Next Bugfix Release

Development

Successfully merging this pull request may close these issues.

3 participants

@davidanthoff @non-Jedi @aviatesk