Merged
Conversation
9 tasks
davidanthoff
reviewed
Jun 9, 2020
Member
davidanthoff
left a comment
davidanthoff
left a comment
There was a problem hiding this comment.
I'm changing this to a draft, because it is not ready to be merged or reviewed, right?
aviatesk
force-pushed
the
avi/documentation
branch
from
78cf9cb to
592f646
Compare
Member
|
@aviatesk needs a merge conflict resolution. |
pfitzseb
reviewed
Jul 1, 2020
| return mismatched_version_error(uri, doc, params, "getDocAt") | ||
| end | ||
|
|
||
| x = get_expr1(getcst(doc), get_offset(doc, params.position)) |
Member
Author
davidanthoff
approved these changes
Jul 1, 2020
Member
davidanthoff
left a comment
davidanthoff
left a comment
There was a problem hiding this comment.
I'm going to merge this now, just so that it is easier to work on the corresponding PR over in the extension itself. There is still the comment from @pfitzseb whether this is using the right function, but I think we can address that in a follow-up PR.
davidanthoff
added a commit
that referenced
this pull request
Jul 5, 2020
show document for `const` variables, follow up #744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #377
currently just borrows logics of
get_hover, and many TODOs left:- [ ] handle links (e.g.@ref)- [ ] horizontal line separators- [ ] documentations on variables, structs- [ ] more accurate documentation retrieve (e.g.Base.sin)Let's address those TODOs later, hacking in LS will take some time.