Conversation
ZacLN
reviewed
Jun 19, 2020
davidanthoff
approved these changes
Jun 20, 2020
Member
davidanthoff
left a comment
davidanthoff
left a comment
There was a problem hiding this comment.
@ZacLN , you should probably also approve.
Do we know what corner case we are guarding against here? Might be good to actually understand the scenario better?
Member
|
@ZacLN should I merge this? |
Member
|
Did @ZacLN review this? I think with the StaticLint stuff it would be good if he looked over things before we merge. |
Contributor
|
HI, yes I had already made comments - all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #767.
I'm not sure when this can happen, but should fix the crash regardless.