Skip to content

disable linting in test folders #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidanthoff merged 6 commits into from
Jul 1, 2020
Merged

disable linting in test folders #776

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3f589b
disable linting in test folders
ZacLN Jun 22, 2020
3fc43d1
remove version branching
ZacLN Jun 24, 2020
72dfb13
Merge branch 'master' into disable-test-lint
davidanthoff Jun 30, 2020
602c271
report some linting in /test
ZacLN Jul 1, 2020
5d00075
Merge branch 'master' into disable-test-lint
davidanthoff Jul 1, 2020
e8141d1
Merge branch 'master' into disable-test-lint
davidanthoff Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove version branching
  • Loading branch information
@ZacLN
ZacLN committed Jun 24, 2020
commit 3fc43d1983c45097decf5d2314ae2bb900575f69
10 changes: 3 additions & 7 deletions src/utilities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,13 +334,9 @@ maybe_lookup(x, server) = x isa SymbolServer.VarRef ? SymbolServer._lookup(x, ge

function is_in_test_dir_of_package(path::String)
try # Safe failure - attempts to read disc.
if VERSION < v"1.1"
return false
else
spaths = splitpath(path)
if (i = findfirst(==("test"), spaths)) !== nothing && "src" in readdir(joinpath(spaths[1:i-1]...))
return true
end
spaths = splitpath(path)
if (i = findfirst(==("test"), spaths)) !== nothing && "src" in readdir(joinpath(spaths[1:i-1]...))
return true
end
return false
catch
Expand Down