Skip to content

Use a command URI for getDocAt #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidanthoff merged 3 commits into from
Jul 6, 2020
Merged

Use a command URI for getDocAt #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22525ee
Use a command URI for getDocAt
davidanthoff Jul 5, 2020
57905c8
Merge branch 'master' into commanduri-for-docs
aviatesk Jul 6, 2020
42997d2
use same API as VSCodeServer
aviatesk Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/requests/features.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ function webview_html(md)
s = html(md)
if haskey(md.meta, :module)
mod = md.meta[:module]
newhref = string("julia-vscode", '/', mod)
newhref = vscode_cmd_uri("language-julia.findHelp"; searchTerm = mod)
s = replace(s, "<a href=\"@ref\"" => "<a href=\"$newhref\"")
end
s = replace(s, CODE_LANG_REGEX => annotate_highlight_js)
Expand Down
8 changes: 8 additions & 0 deletions src/utilities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# VSCode specific
# ---------------

nodocuemnt_error(uri, data = nothing) =
return JSONRPC.JSONRPCError(-32099, "document $(uri) requested but not present in the JLS", data)

Expand All @@ -9,6 +12,11 @@ function mismatched_version_error(uri, doc, params, msg, data = nothing)
)
end

vscode_cmd_uri(cmd; cmdargs...) = string("command:", cmd, '?', URIParser.escape(JSON.json(cmdargs)))

# misc
# ----

function uri2filepath(uri::AbstractString)
parsed_uri = try
URIParser.URI(uri)
Expand Down