Merged
Conversation
pfitzseb
approved these changes
Jul 14, 2020
Member
pfitzseb
left a comment
pfitzseb
left a comment
There was a problem hiding this comment.
Seems like a good-enough short term solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #797.
This is the minimal fix I came up with for the CI testing. Unfortunately it does require one change to the package code just to fix the tests, but I couldn't come up with a better idea.
The problem here is that for the LS tests we don't set up a full communication channel, and so we need a way to make sure things like sending diagnostics don't error. My plan had be to enable a full mocking story, but I never finished this, so this is a somewhat lame emulation of that: if the endpoint is
nothing, in the test case we make sending a notification to such a nothing endpoint a no op. I know how to improve this generally, but that would require more refactoring of the code that ships to users, so I think that should probably wait until after Juliacon, and for now we go with this minimal fix to get back our CI testing.The reason this slipped into
masterin the first place was that a JSONRPC.jl update exposed a bug in the LS tests.