Merged
Conversation
Member
|
I'm in favor of this -- as far as I understand binding traversal in LanguageServer.jl itself seems to be correct, so I think there won't be anything we can get more from crash report for these lines of code. |
aviatesk
reviewed
Jul 15, 2020
| function get_signatures(b, tls, sigs, server, visited = nothing) end # Fallback | ||
|
|
||
| function get_signatures(b::StaticLint.Binding, tls::StaticLint.Scope, sigs::Vector{SignatureInformation}, server, visited = Base.IdSet{StaticLint.Binding}()) | ||
| function get_signatures(b::StaticLint.Binding, tls::StaticLint.Scope, sigs::Vector{SignatureInformation}, server, visited = StaticLint.Binding[]) |
Member
There was a problem hiding this comment.
What's the reason for switching to Vector ?
Well, could I also ask why you used Base.IdSet before instead of usual Set ?
Contributor
Author
There was a problem hiding this comment.
Using IdSet was a mistake, I had been using them in SymbolServer and forgot it was quite costly
davidanthoff
approved these changes
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a cycle in the links (
.prev/.next) between StaticLint.Bindings. The root cause is within StaticLint but there is no reason to allow it to crash the language server. If we have done a complete circuit here (i.e. a loop is detected) then we have all the information we need and canreturn.As this is being hit quite a lot, this approach seems best for the user while the StaticLint bug is fixed. Thoughts?