Conversation
pfitzseb
left a comment
pfitzseb
left a comment
There was a problem hiding this comment.
Let's turn incremental sync back on and see what happens, at least in the next insiders release? I kinda hope that all the code churn here and in CSTParser might've fixed the issues we had.
src/requests/init.jl
Outdated
| false, | ||
| ExecuteCommandOptions(missing, collect(keys(LSActions))), | ||
| false, | ||
| true, |
There was a problem hiding this comment.
This is selectionRangeProvider, right? Did we always support that? If so, why was it disabled?
There was a problem hiding this comment.
I must have been fiddling with something, will turn off
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
|
@julia-vscode/core could someone with a windows computer try to get this passing? Debugging by pushing to CI runs is a nightmare. The issue is with path handling on older Julia verions (<1.1 I think, possibly <1.3). Relevant code is https://github.com/julia-vscode/LanguageServer.jl/blob/master/src/utilities.jl#L286:L309 or there abouts |
| const serverCapabilities = ServerCapabilities( | ||
| TextDocumentSyncOptions(true, | ||
| TextDocumentSyncKinds.Full, | ||
| TextDocumentSyncKinds.Incremental, |
2 participants
Amendments for CSTParser changes (julia-vscode/CSTParser.jl#190)