Skip to content

Update to new client lib version#866

Merged
davidanthoff merged 1 commit intomasterfrom
update-to-new-lsclient
Jan 24, 2021
Merged

Update to new client lib version#866
davidanthoff merged 1 commit intomasterfrom
update-to-new-lsclient

Conversation

@davidanthoff
Copy link
Copy Markdown
Member

The new client side lib version sends a new client id, and so our insider build is crashing at the moment. I'm going to merge this right away to fix that. Review after the fact would be great.

@davidanthoff davidanthoff added this to the Next Patch milestone Jan 24, 2021
@davidanthoff davidanthoff merged commit 7bb57dc into master Jan 24, 2021
@davidanthoff davidanthoff deleted the update-to-new-lsclient branch January 24, 2021 05:27
@ZacLN
Copy link
Copy Markdown
Contributor

ZacLN commented Jan 24, 2021

Should this continue to check against 'vscode' as well to continue to support older versions?

@davidanthoff
Copy link
Copy Markdown
Member Author

I'm modestly certain that this string originates from the vscode-languageclient v7.0.0 npm package and not from VS Code itself. If that is true, we should be good because we control which version of that package we ship. I think I also bumped the min version of VS Code that we run on as well for the pkg tag stuff, so I think we should be fairly safe that this will never run with older versions.

Having said that, having both in probably also wouldn't do any harm :)

@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants