Add a check for strings with NULL#895
Merged
Merged
Conversation
ZacLN
approved these changes
Feb 15, 2021
pfitzseb
reviewed
Feb 16, 2021
| end | ||
|
|
||
| return pos | ||
| return pos |
Member
There was a problem hiding this comment.
These whitespace changes are a regression in DocumentFormat.jl, I think. Should figure out what's going on there...
Member
Author
There was a problem hiding this comment.
Argh, I didn't even notice these when I created the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with https://github.com/julia-vscode/crashreporting-issues/issues/8.
For every PR, please check the following: