Skip to content

Document highlight refactor#911

Merged
davidanthoff merged 4 commits intomasterfrom
sp/document-highlight
May 20, 2021
Merged

Document highlight refactor#911
davidanthoff merged 4 commits intomasterfrom
sp/document-highlight

Conversation

@pfitzseb
Copy link
Copy Markdown
Member

Factor out common code for #908.

For every PR, please check the following:

@davidanthoff
Copy link
Copy Markdown
Member

@pfitzseb what is the status of this? It needs a milestone and label etc.

@pfitzseb pfitzseb added this to the Next Minor milestone May 12, 2021
@pfitzseb
Copy link
Copy Markdown
Member Author

This is basically just a slight refactor for #908 and should be merged at the same time as that PR.

Copy link
Copy Markdown
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs merge conflict resolution.

@pfitzseb pfitzseb requested a review from davidanthoff May 20, 2021 13:28
Copy link
Copy Markdown
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment tests seem to fail. Not clear to me whether that is actually related to this PR, but tests on master seem to pass, so my best guess is that this is somehow related to this PR?

@pfitzseb pfitzseb requested a review from davidanthoff May 20, 2021 21:51
@davidanthoff davidanthoff merged commit a82b28d into master May 20, 2021
@davidanthoff davidanthoff deleted the sp/document-highlight branch May 20, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants