Skip to content

fix kwarg hover printing #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfitzseb merged 1 commit into from
Mar 29, 2021
Merged

fix kwarg hover printing #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/requests/hover.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,9 @@ function get_hover(b::StaticLint.Binding, documentation::String, server)
else
documentation
end
documentation = string(documentation, "```julia\n", Expr(b.val), "\n```\n")
documentation = string(documentation, "```julia\n", prettify_expr(Expr(b.val)), "\n```\n")
catch err
@error "get_hover failed to convert Expr" exception = (err, catch_backtrace())
throw(LSHoverError(string("get_hover failed to convert Expr")))
end
end
Expand All @@ -65,6 +66,16 @@ function get_hover(b::StaticLint.Binding, documentation::String, server)
return documentation
end

function prettify_expr(ex::Expr)
if ex.head === :kw && length(ex.args) == 2
string(ex.args[1], " = ", ex.args[2])
else
string(ex)
end
end

prettify_expr(ex) = string(ex)

# print(io, x::SymStore) methods are defined in SymbolServer
function get_hover(b::SymbolServer.SymStore, documentation::String, server)
if !isempty(b.doc)
Expand Down