Skip to content

make symbolcache downloads configurable #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidanthoff merged 1 commit into from
Jul 19, 2021
Merged

make symbolcache downloads configurable #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
make symbolcache downloads configurable
  • Loading branch information
@pfitzseb
pfitzseb committed Jul 19, 2021
commit 4504b14f9c756cb14488fe8ef178ddc1ef2e7d7f
12 changes: 9 additions & 3 deletions src/languageserverinstance.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ mutable struct LanguageServerInstance
status::Symbol

number_of_outstanding_symserver_requests::Int
symserver_use_download::Bool

current_symserver_progress_token::Union{Nothing,String}

Expand All @@ -63,7 +64,7 @@ mutable struct LanguageServerInstance

shutdown_requested::Bool

function LanguageServerInstance(pipe_in, pipe_out, env_path="", depot_path="", err_handler=nothing, symserver_store_path=nothing)
function LanguageServerInstance(pipe_in, pipe_out, env_path="", depot_path="", err_handler=nothing, symserver_store_path=nothing, download=true)
new(
JSONRPC.JSONRPCEndpoint(pipe_in, pipe_out, err_handler),
Set{String}(),
Expand All @@ -80,11 +81,12 @@ mutable struct LanguageServerInstance
StaticLint.LintOptions(),
:all,
LINT_DIABLED_DIRS,
:import, # options: :import or :qualify, anything else turns this off
:qualify, # options: :import or :qualify, anything else turns this off
Channel{Any}(Inf),
err_handler,
:created,
0,
download,
nothing,
false,
false,
Expand Down Expand Up @@ -171,6 +173,10 @@ function trigger_symbolstore_reload(server::LanguageServerInstance)
end
server.number_of_outstanding_symserver_requests += 1

if server.symserver_use_download
@debug "Will download symbol server caches for this instance."
end

@async try
# TODO Add try catch handler that links into crash reporting
ssi_ret, payload = SymbolServer.getstore(
Expand All @@ -188,7 +194,7 @@ function trigger_symbolstore_reload(server::LanguageServerInstance)
end
end,
server.err_handler,
download = true
download = server.symserver_use_download
)

server.number_of_outstanding_symserver_requests -= 1
Expand Down