Skip to content

add quickaction to remove unused farg name #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfitzseb merged 3 commits into from
Sep 6, 2021
Merged

add quickaction to remove unused farg name #981

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75938e2
add quickaction to remove unused farg name
ZacLN Aug 11, 2021
1e19be9
add test :)
ZacLN Aug 23, 2021
58245c6
Merge branch 'master' into unused-farg
davidanthoff Sep 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add quickaction to remove unused farg name
  • Loading branch information
@ZacLN
ZacLN committed Aug 11, 2021
commit 75938e2ca155c2454a59ea21793752296a4d5cce
18 changes: 17 additions & 1 deletion src/requests/actions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,21 @@ function applymissingreffix(x, server, conn)
end
end

function remove_farg_name(x, server, conn)
x1 = StaticLint.get_parent_fexpr(x, x -> StaticLint.haserror(x) && StaticLint.errorof(x) == StaticLint.UnusedFunctionArgument)
file, offset = get_file_loc(x1)
if CSTParser.isdeclaration(x1)
tde = TextDocumentEdit(VersionedTextDocumentIdentifier(file._uri, file._version), TextEdit[
TextEdit(Range(file, offset .+ (0:x1.args[1].fullspan)), "")
])
else
tde = TextDocumentEdit(VersionedTextDocumentIdentifier(file._uri, file._version), TextEdit[
TextEdit(Range(file, offset .+ (0:x1.fullspan)), "::Any")
])
end
JSONRPC.send(conn, workspace_applyEdit_request_type, ApplyWorkspaceEditParams(missing, WorkspaceEdit(missing, TextDocumentEdit[tde])))
end

# Adding a CodeAction requires defining:
# * a Command (title and description);
# * a function (.when) called on the currently selected expression and parameters of the CodeAction call;
Expand All @@ -268,5 +283,6 @@ const LSActions = Dict(
applymissingreffix),
"ReexportModule" => ServerAction(Command("Re-export package variables.", "ReexportModule", missing),
(x, params) -> StaticLint.is_in_fexpr(x, x -> headof(x) === :using || headof(x) === :import) && (refof(x) isa StaticLint.Binding && (refof(x).type === StaticLint.CoreTypes.Module || (refof(x).val isa StaticLint.Binding && refof(x).val.type === StaticLint.CoreTypes.Module) || refof(x).val isa SymbolServer.ModuleStore) || refof(x) isa SymbolServer.ModuleStore),
reexport_package)
reexport_package),
"DeleteUnusedFunctionArgumentName" => ServerAction(Command("Delete name of unused function argument.", "DeleteUnusedFunctionArgumentName", missing), (x, params) -> StaticLint.is_in_fexpr(x, x -> StaticLint.haserror(x) && StaticLint.errorof(x) == StaticLint.UnusedFunctionArgument), remove_farg_name)
)