Fix document symbols for function-like objects#990
Merged
pfitzseb merged 2 commits intojulia-vscode:masterfrom Nov 4, 2021
Merged
Fix document symbols for function-like objects#990pfitzseb merged 2 commits intojulia-vscode:masterfrom
pfitzseb merged 2 commits intojulia-vscode:masterfrom
Conversation
Member
|
Cool, thanks for the fix! Would you mind adding a test hereabouts for this? |
pfitzseb
approved these changes
Nov 4, 2021
Member
|
Added a test in 915c462. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes julia-vscode/julia-vscode#2303
Function-like objects were being rejected as valid bindings by
is_valid_binding_nameand so all symbols in their scope were escaping.I don't know if it's the most intuitive but right now I have on
::TheTypefor the name given to callable object symbols.