-
Notifications
You must be signed in to change notification settings - Fork 50
Documentation for fast debugging #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
section for all modules except main
- Loading branch information
commit 245949f868a05bae8c298b7cae9aba74c66c290e
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth noting that there is also a bit of UI for this, maybe?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. However, ALL_MODULES_EXCEPT_MAIN is something to be set in the settings.json I think, before doing any debugging, I don't know other way to do it.
If we use ALL_MODULES_EXCEPT_MAIN, no other symbols appear to be loaded in the "All" list such that the user can further add other modules from the UI.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, if you debug one more time, all desired symbols appears in the "All" list. But these are expected to appear as compiled instead of interpreted, right?

If you make one of the modules in the "All" list to be "compiled", the "All" list dissapears. Looks like a little bug here. In addition, this operation is very slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a few more tests I noticed I can do the following: add ALL_MODULES_EXCEPT_MAIN from UI.

But now If I want to remove the Statistics, I just cannot do it. One workaround was to add it as compiled (again?), and then remove it, but this just doesn't work from the UI:

Result after removing Statistics from the UI, hoping it will become interpreted. Unfortunately, this did not work:

Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pfitzseb while I have managed to add ALL_MODULES_EXCEPT_MAIN from the UI, I have found the UI option quite unreliable, see the above issues with the Statistics and the "All" list not expanding properly etc.
Additionally, you don't want to get the GLMakie in the interpreted mode, not even a single time. Currently, I think it's best to add ALL_MODULES_EXCEPT_MAIN directly in the settings.json such that expensive packages will get compiled from the very first time.
Here I see 2 options:
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just merge the PR :) Thanks again!