Cygwin filepaths and git (windows build) on Cygwin Vim

[evandrocoan]

After searching I found #556 fatal: destination path '/home/...' already exists and is not an empty

Now I see the message destination path already exists and is not an empty directory is probably coming from git. The git version on my system path is git version 2.21.0.windows.1, and it is the one I want to use. I do not see why it should break a vim package manager.

Installed Cygwin and vim. Now when I run :PlugInstall for the second time (after installing everything successfully first) it says destination path already exists and is not an empty directory. But it should say something like All up to date because everything is already installed and up-to-date:

  1 Updated. Elapsed time: 0.218449 sec.
  2 [xxx]
  3
  4 - Finishing ... Done!
  5 x vim-hug-neovim-rpc:
  6     fatal: destination path '/home/Professional/.vim/plugged/vim-hug-neovim-rpc' already exists and is not an empty directory.
  7 x deoplete.nvim:
  8     fatal: destination path '/home/Professional/.vim/plugged/deoplete.nvim' already exists and is not an empty directory.
  9 x nvim-yarp:
 10     fatal: destination path '/home/Professional/.vim/plugged/nvim-yarp' already exists and is not an empty directory.

---

.vimrc

" https://github.com/junegunn/vim-plug/wiki/tips
" https://github.com/junegunn/vim-plug/issues/894
if v:version >= 740

  if empty(glob('~/.vim/autoload/plug.vim'))
    let s:downloadurl = "https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim"
    let s:destinedirectory = $HOME . "/.vim/autoload/"
    let s:destinefile = s:destinedirectory . "plug.vim"

    if !isdirectory(s:destinedirectory)
      call mkdir(s:destinedirectory, "p")
    endif

    if executable("curl")
      silent execute '!curl --output ' . s:destinefile .
          \ ' --create-dirs --location --fail --silent ' . s:downloadurl

    else
      silent execute '!wget --output-document ' . s:destinefile .
          \ ' --no-host-directories --force-directories --quiet ' . s:downloadurl
    endif

    autocmd VimEnter * PlugInstall --sync | source $MYVIMRC
  endif

  " https://github.com/junegunn/vim-plug
  "
  " Specify a directory for plugins
  " - For Neovim: stdpath('data') . '/plugged'
  " - Avoid using standard Vim directory names like 'plugin'
  call plug#begin('~/.vim/plugged')

  if v:version >= 800

    if has('nvim')
      Plug 'Shougo/deoplete.nvim', { 'do': ':UpdateRemotePlugins' }
    else
      Plug 'Shougo/deoplete.nvim'
      Plug 'roxma/nvim-yarp'
      Plug 'roxma/vim-hug-neovim-rpc'
    endif
    let g:deoplete#enable_at_startup = 1

  endif

  " Initialize plugin system
  call plug#end()

endif

• Type:
  • Bug
  • Enhancement
  • Feature Request
  • Question
• OS:
  • All/Other
  • Linux
  • OS X
  • Windows
• Vim:
  • Terminal Vim
  • GVim
  • Neovim

$ vim --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Mar  4 2018 23:29:48)
Included patches: 1-1567
Modified by <cygwin@cygwin.com>
Compiled by <cygwin@cygwin.com>
Huge version without GUI.  Features included (+) or not (-):
+acl               +farsi             +mouse_sgr         -tag_any_white
+arabic            +file_in_path      -mouse_sysmouse    -tcl
+autocmd           +find_in_path      +mouse_urxvt       +termguicolors
-autoservername    +float             +mouse_xterm       +terminal
-balloon_eval      +folding           +multi_byte        +terminfo
+balloon_eval_term -footer            +multi_lang        +termresponse
-browse            +fork()            -mzscheme          +textobjects
++builtin_terms    +gettext           +netbeans_intg     +timers
+byte_offset       -hangul_input      +num64             +title
+channel           +iconv             +packages          -toolbar
+cindent           +insert_expand     +path_extra        +user_commands
-clientserver      +job               +perl/dyn          +vertsplit
+clipboard         +jumplist          +persistent_undo   +virtualedit
+cmdline_compl     +keymap            +postscript        +visual
+cmdline_hist      +lambda            +printer           +visualextra
+cmdline_info      +langmap           +profile           +viminfo
+comments          +libcall           +python/dyn        +vreplace
+conceal           +linebreak         +python3/dyn       +wildignore
+cryptv            +lispindent        +quickfix          +wildmenu
+cscope            +listcmds          +reltime           +windows
+cursorbind        +localmap          +rightleft         +writebackup
+cursorshape       +lua/dyn           +ruby/dyn          -X11
+dialog_con        +menu              +scrollbind        -xfontset
+diff              +mksession         +signs             -xim
+digraphs          +modify_fname      +smartindent       -xpm
-dnd               +mouse             +startuptime       -xsmp
-ebcdic            -mouseshape        +statusline        -xterm_clipboard
+emacs_tags        +mouse_dec         -sun_workshop      -xterm_save
+eval              -mouse_gpm         +syntax
+ex_extra          -mouse_jsbterm     +tag_binary
+extra_search      +mouse_netterm     +tag_old_static
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/etc"
 f-b for $VIMRUNTIME: "/usr/share/vim/vim80"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H     -ggdb -O2 -pipe -Wall -Werror=format-security -fstack-protector-strong --param=ssp-buffer-size=4 -fdebug-prefix-map=/usr/src/ports/vim/vim-8.0.1567-1.x86_64/build=/usr/src/debug/vim-8.0.1567-1 -fdebug-prefix-map=/usr/src/ports/vim/vim-8.0.1567-1.x86_64/src/vim-8.0.1567=/usr/src/debug/vim-8.0.1567-1 -fstack-protector-strong -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L. -fstack-protector  -L/usr/local/lib -Wl,--as-needed -o vim.exe        -lm -lelf -lnsl    -lncursesw -liconv -lacl -lattr -lintl   -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--enable-auto-image-base -fstack-protector-strong  -L/usr/lib/perl5/5.26/x86_64-cygwin-threads/CORE -lperl -lpthread -ldl -lcrypt

[yugr]

This is likely due to Windows git failing to understand Cygwin's path conventions (~/.vim, etc.). At least in Vundle this can be workarounded by converting path to mixed style:

  let vimdir = '~/.vim/plugged'
  if has('win32unix')
    " Use mixed path on Cygwin so that Windows git works
    let vimdir = substitute(system('cygpath -m ' . vimdir), '\n\+$', '', '')
  endif
  call vundle#begin(vimdir)

but same trick does not work for me in plug#begin.

[janlazo]

Is your vimrc is in ~/.vim/vimrc where ~ is equal to $HOME in Vim or %USERPROFILE% in cmd.exe?

" in vimrc
let s:base_dir = expand('<sfile>:p:h')
call plug#begin(s:base_dir . '/plugged')

Does this help?

[yugr]

Is your vimrc is in ~/.vim/vimrc

Actually it's ~/.vimrc.

call plug#begin(s:base_dir . '/plugged')

I assume you meant '/.vim/plugged'?

Does this help?

Nope, s:base_dir is just /home/iuriig which is unsuitable for Windows git. But even converting it to $(cygpath -m /home/iuriig) (i.e. C:/cygwin64/home/iuriig) as in the code I posted above does not solve the issue.

[evandrocoan]

I managed to make vim-plug to clone the repositories by changing this line:
https://github.com/junegunn/vim-plug/blob/master/plug.vim#L128

To:

  let g:plug_home = 'F:\\Cygwin\\home\\Professional\\.vim\\plugged'

Then, after successfull cloning the repositories on .vim\\plugged, it throw this error:

[Plugins]                                                                       [No Name]
Error detected while processing function <SNR>8_install[1]..<SNR>8_update_impl[110]..<SNR>8_job_cb[4]..<SNR>8_job_exit_cb[4]..<SNR>8_tick[6]..<SNR>8_update_fi
nish[56]..<SNR>8_finish[9]..plug#end[89]..<SNR>8_reload_plugins[2]..<SNR>8_load_plugin[1]..<SNR>8_source:
line    4:
E484: Can't open file F:CygwinhomeProfessional.vimplugged/deoplete.nvim/plugin/deoplete.vim

[janlazo]

Is your request for vim-plug to support both windows and cygwin builds of git?

s:source should use expand (or use fnamemodify) on the filepath before sourcing the file.

[yugr]

@evandrocoan Can you try with 'F:/Cygwin/home/Professional/.vim/plugged'?

[yugr]

@janlazo Basically yes, the request is to support using Windows git with Cygwin vim. For this vim-plug can either convert paths internally (from Cygwin's Unix-style format like /home/user/.vim/plugged to c:/cygwin64/home/user/.vim/plugged, this is achieved by cygpath program) or be careful to preserve path given to plug#begin (i.e. not let it be converted to Unix-style along the way). I can try to come up with a patch if this feature is considered useful for the project.

[evandrocoan]

@yugr, yes. It worked 100% and now I got no errors anymore from vim-plug.

@janlazo, yes. As @yugr just showed:

1. The path should be in the form C:/Users/home/.vim/plugged for git for Windows.
2. The path should be in the form /home/.vim/plugged for git for Cygwin.

[evandrocoan]

@janlazo, by running this:

fixedpath="$(cygpath --mixed --absolute "$HOME/.vim/plugged")"

You would get F:/Cygwin/home/Professional/.vim/plugged in the variable fixedpath

[yugr]

@evandrocoan Great.

So basically all that's needed is for vim-plug to preserve path given to plug#begin (as C:/Users/home/user/.vim/plugged) without converting it to Unix style (/home/user/.vim/plugged). Currently this conversion happens in fnamemodify at start of plug#begin:

function! plug#begin(...)
  if a:0 > 0
    let s:plug_home_org = a:1
    let home = s:path(fnamemodify(expand(a:1), ':p'))

I think one way to fix this would be to call cygpath after computation of home in plug#begin:

function! plug#begin(...)
  if a:0 > 0
    let s:plug_home_org = a:1
    let home = s:path(fnamemodify(expand(a:1), ':p'))
  ...
  if fnamemodify(home, ':t') ==# 'plugin' && fnamemodify(home, ':h') ==# s:first_rtp
    return s:err('Invalid plug home. '.home.' is a standard Vim runtime path and is not allowed.')
  endif
  if has('win32unix')
    " Use mixed path on Cygwin so that Windows git works
    let home = substitute(system('cygpath -m ' . home), '\n\+$', '', '')
  endif

[evandrocoan]

o basically all that's needed is for vim-plug to preserve path given to plug#begin (as C:/Users/home/user/.vim/plugged) without converting it to Unix style (/home/user/.vim/plugged). Currently this conversion happens in fnamemodify at start of plug#begin:

@yugr, now I see why I got a lot of trouble while trying to make it work. I was setting the path, but it was being converted back.

Also, do not forget, that this patch should only be used if the the program cygpath available. For example:

if executable("cygpath")
  if has('win32unix')
    " Use mixed path on Cygwin so that Windows git works
    let home = substitute(system('cygpath -m ' . home), '\n\+$', '', '')
  endif
endif

[yugr]

"Also, do not forget, that this patch should only be used if the the program cygpath available" - true but win32unix guarantees that we are in Cygwin and cygpath is always available there (it comes with base installation).