jupyter-js-services #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gnestor
commented
Nov 29, 2015
gnestor
commented
- Switched from jupyter-kernel-launcher to jupyter-js-services
- Switched from iPython server to Jupyter Kernel Gateway
- Added keymap and menu commands
- Updated style to match native UI and syntax themes
- Fixed issue with process.env.PATH so that it can spawn child processes without requiring Atom to be launched from the command line
- Fixed issue with receiving Jupyter stream/async messages
Compatible with Node >=4
Requires that a Jupyter Notebook server be running BUG: Jupyter Notebook server throws CORS exception
Add XMLHttpRequest and WebSocket to globals Remove leftover references to jupyter-kernel-launcher
jupyter/services@7d213853e923fc23d4 046541a951664c6c604fa5
Kill on close
Member
|
Well this is awesome. Thank you @gnestor! |
Member
|
I'm glad you're using the kernel gateway here too. /cc @parente |
Member
|
I'm going to go ahead and merge this so you can shipit and iterate freely. This hasn't been touched in a while; it's good to have you. |
Contributor
Author
|
@rgbkrk Happy to help. Thanks for adding me to the repo. More to come... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.