Skip to content

Remove reliance on netstat / lsof to find an open port #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnestor merged 1 commit into from
Dec 8, 2015
Merged

Remove reliance on netstat / lsof to find an open port #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions lib/notebook-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use babel';

import path from 'path';
import portfinder from 'portfinder';
import fs from 'fs-plus';
import React from 'react';
import uuid from 'uuid';
Expand Down Expand Up @@ -262,13 +263,9 @@ export default class NotebookEditor {

launchKernelGateway() {
let language = this.state.getIn(['metadata', 'kernelspec', 'language']);
let port = 8888;
try {
do {
execSync(`netstat -np TCP | grep "${port}"`);
port++;
} while (port < 9000);
} catch(error) {
portfinder.basePort = 8888;
portfinder.getPort(function(err, port){
if (err) throw err;
this.kernelGateway = spawn('jupyter', ['kernelgateway', '--KernelGatewayApp.ip=localhost', `--KernelGatewayApp.port=${port}`], {
cwd: atom.project.getPaths()[0]
});
Expand Down Expand Up @@ -299,7 +296,7 @@ export default class NotebookEditor {
this.kernelGateway.on('exit', (code) => {
console.log('kernelGateway.exit ' + code);
});
}
});
}

makeOutputBundle(msg) {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"immutable": "^3",
"jupyter-js-services": ">=0.2.1",
"pathwatcher": ">=4.4.3",
"portfinder": "^0.4.0",
"react": "^0.14",
"react-dom": "^0.14.3",
"transformime": "^1",
Expand Down