declarative: add WithPreserveNamespace option #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option prevents the Reconciler from deploying all objects in the same namespace as the DeclarativeObject. Generally, we do want the namespace behavior because it makes things like OwnerRef's work, but there are exceptions that need to control this themselves.
reduce spam and make it easier to read
justinsb
pushed a commit
that referenced
this pull request
Mar 23, 2021
⚒️ add additional controller tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option prevents the Reconciler from deploying all objects in the
same namespace as the DeclarativeObject.
Generally, we do want the namespace behavior because it makes things
like OwnerRef's work, but there are exceptions that need to control this
themselves.