This repository was archived by the owner on Apr 14, 2025. It is now read-only.
Lazy load headers so we can still set delimiter / enclosure #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
jwage
added a commit
that referenced
this pull request
Feb 17, 2013
Lazy load headers so we can still set delimiter / enclosure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CSV with headers and not using comma as delimiter or not using '"' as enclosure couldn't be parsed since the headers were parsed in the constructor, which is ofcourse before a EasyCSV\AbstractBase::setDelimiter or EasyCSV\AbstractBase::setEnclosure call
Fixed this by lazy loading the headers.